Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

good-console test not compatible with v4 #52

Closed
lloydbenson opened this issue Sep 15, 2015 · 1 comment
Assignees
Labels
bug
Milestone

Comments

@lloydbenson
Copy link
Contributor

@lloydbenson lloydbenson commented Sep 15, 2015

good-console won't test with node v4. I'd recommend removing the "stand-in" module as a dependency.

@arb

This comment has been minimized.

Copy link
Contributor

@arb arb commented Sep 20, 2015

Yeah the issue is stand-in uses obj-hash which doesn't work in v4 yet either. See related issue lxe/node-objhash#3. I think stand-in might get updated to avoid obj-hash.

@arb arb added the bug label Sep 20, 2015
@arb arb self-assigned this Sep 20, 2015
@arb arb added this to the 5.1.0 milestone Sep 21, 2015
@arb arb closed this in 084da74 Sep 21, 2015
lloydbenson added a commit that referenced this issue Sep 21, 2015
Fixes node 4 issue. Closes #52.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.