Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass event.id for Error and Response format #100

Merged
merged 1 commit into from Jan 16, 2018

Conversation

@poupougnac
Copy link
Contributor

poupougnac commented Dec 21, 2017

Hi,
The accepted PR #80 was very useful for my case but I don't understand why the id is only set into the formatDefault function. We could also take advantage of it for error and response.
Any thoughts ?

@poupougnac poupougnac force-pushed the poupougnac:master branch from 8487487 to edcb0da Dec 21, 2017
@poupougnac poupougnac changed the title Pass event.id for every format Pass event.id for Error and Response format Dec 29, 2017
@poupougnac poupougnac closed this Dec 29, 2017
@poupougnac poupougnac reopened this Dec 29, 2017
@poupougnac

This comment has been minimized.

Copy link
Contributor Author

poupougnac commented Jan 2, 2018

@arb, would you mind taking a look on this ?
Happy new year BTW :)

@arb arb self-assigned this Jan 10, 2018
@arb arb added this to the 7.0.0 milestone Jan 10, 2018
@arb

This comment has been minimized.

Copy link
Contributor

arb commented Jan 10, 2018

Please rebase in master.

@poupougnac poupougnac force-pushed the poupougnac:master branch from edcb0da to 19df92c Jan 10, 2018
@poupougnac

This comment has been minimized.

Copy link
Contributor Author

poupougnac commented Jan 10, 2018

Done.

@arb arb merged commit 0ab557d into hapijs:master Jan 16, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.