Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SafeStringify when serializing the query #103

Merged
merged 1 commit into from Feb 12, 2018

Conversation

@danielo515
Copy link
Contributor

danielo515 commented Feb 9, 2018

On hapi services a query object can pass through multiple stages and plugins. Some of those plugins can inadvertently inject non-serializable data (like circular references). Since you already have SafeStringify available i think it makes sense to use it for this serialization too.

@NoeliaCuesta

On hapi services a query object can pass through multiple stages and plugins. Some of those plugins can inadvertently inject non-serializable data (like circular references). Since you already have `SafeStringify` available  i think it makes sense to use it for this serialization too.

@NoeliaCuesta
@danielo515

This comment has been minimized.

Copy link
Contributor Author

danielo515 commented Feb 12, 2018

Hello,

What is stopping this from getting merged ?
Regards

@arb arb added the feature label Feb 12, 2018
@arb arb added this to the 7.1.0 milestone Feb 12, 2018
@arb arb self-assigned this Feb 12, 2018
@arb arb merged commit 388b0fa into hapijs:master Feb 12, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@arb

This comment has been minimized.

Copy link
Contributor

arb commented Feb 12, 2018

I'm going to hold off pushing 7.1.0 for a few days as there have been changes in good@8.1.0 and I'm sure that's going to cause downstream changes.

@danielo515

This comment has been minimized.

Copy link
Contributor Author

danielo515 commented Feb 12, 2018

Hello @arb,
Thank you very much.
Will be available a list of breaking changes? We use good in production intensively and we really need this fix.
If the changes are too disruptive, will be an option to cherri pick this change into the current version?

Thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.