Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages #107

Closed
wants to merge 5 commits into from

Conversation

@erfanio
Copy link

erfanio commented May 5, 2018

Update packages
and fix tests

erfanio added 2 commits May 5, 2018
@erfanio

This comment has been minimized.

Copy link
Author

erfanio commented May 5, 2018

Hmmm looks like travis config needs changing too

@erfanio

This comment has been minimized.

Copy link
Author

erfanio commented May 12, 2018

@arb how does this look?

@arb arb added this to the 8.0.0 milestone May 14, 2018
"code": "4.x.x",
"lab": "14.x.x"
"code": "5.x.x",
"lab": "15.x.x"
},
"engines": {
"node": ">=4.x.x"

This comment has been minimized.

Copy link
@arb

arb May 14, 2018

Contributor

Make sure you update this too

@erfanio

This comment has been minimized.

Copy link
Author

erfanio commented May 15, 2018

@arb done 🚀

@arb

This comment has been minimized.

Copy link
Contributor

arb commented May 15, 2018

So since this uses joi@13, do we need to copy it's node engine setting? https://github.com/hapijs/joi/blob/master/package.json#L13-L15

@erfanio

This comment has been minimized.

Copy link
Author

erfanio commented May 15, 2018

Yeh we should

I just copied Good's engine version which seems to need updating too.

It's really weird tho, npm doesn't give any warnings but yarn completely fails on node 8 because of hoek, seems like npm is ignoring engine

@arb arb closed this Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.