Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrote event printing logic to be cleaner #29

Merged
merged 3 commits into from Dec 23, 2014

Conversation

@arb
Copy link
Contributor

arb commented Dec 23, 2014

Closes #28.

Also added some docs on how the events will look on the console.

@arb arb added this to the 4.0.0 milestone Dec 23, 2014
- 0.10
- 0.11

This comment has been minimized.

Copy link
@lloydbenson

lloydbenson Dec 23, 2014

Contributor

new line

eventPrintData.data = 'memory: ' + Math.round(eventData.proc.mem.rss / (1024 * 1024)) +
'Mb, uptime (seconds): ' + eventData.proc.uptime +
', load: ' + eventData.os.load;

This comment has been minimized.

Copy link
@lloydbenson

lloydbenson Dec 23, 2014

Contributor

extra line

@@ -109,7 +109,9 @@ describe('GoodConsole', function () {

console.log = function (value) {

expect(value).to.equal(timeString + ', response, localhost: post /data {"name":"adam"} 200 (150ms) response payload: {"foo":"bar","value":1}');
console.info(value);

This comment has been minimized.

Copy link
@lloydbenson

lloydbenson Dec 23, 2014

Contributor

extra line and possibly extra console

lloydbenson added a commit that referenced this pull request Dec 23, 2014
Rewrote event printing logic to be cleaner
@lloydbenson lloydbenson merged commit 348450b into hapijs:master Dec 23, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@arb arb deleted the arb:output-update branch Dec 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.