Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct the key of the configuration object #45

Merged
merged 2 commits into from Jun 4, 2015

Conversation

@paulovieira
Copy link
Contributor

paulovieira commented Jun 4, 2015

The documentation says the optional configuration should be given like this:

options: { format: "YYYYMMDD" }

But should be "config", not "options":

config: { format: "YYYYMMDD" }
@arb

This comment has been minimized.

Copy link
Contributor

arb commented Jun 4, 2015

You should change the name of the value in the code as well if you are going to make this change.

@paulovieira

This comment has been minimized.

Copy link
Contributor Author

paulovieira commented Jun 4, 2015

The pr has been updated. I also spotted another reference to "options" in the title:

GoodConsole(events, [options])

It's been corrected.

@arb arb added this to the 5.0.2 milestone Jun 4, 2015
@arb arb self-assigned this Jun 4, 2015
arb added a commit that referenced this pull request Jun 4, 2015
correct the key of the configuration object
@arb arb merged commit b595ff9 into hapijs:master Jun 4, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.