Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFixed momentjs deprecation warning. Closes #47. #48
Conversation
lib/index.js
Outdated
| @@ -102,7 +102,7 @@ internals.GoodConsole.prototype.init = function (stream, emitter, callback) { | |||
|
|
|||
| internals.GoodConsole.prototype._printEvent = function (event) { | |||
|
|
|||
| var m = Moment.utc(event.timestamp); | |||
| var m = Moment(new Date(parseInt(event.timestamp, 10))); | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
arb
Aug 13, 2015
Author
Contributor
Incase event.timestamp is a string. Then you'll get the deprecation warning which is what this is supposed to fix.
This comment has been minimized.
This comment has been minimized.
geek
Aug 13, 2015
Member
I see that now... but you don't need to make it a Date
var m = Moment(parseInt(event.timestamp, 10));
This comment has been minimized.
This comment has been minimized.
geek
added a commit
that referenced
this pull request
Aug 17, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
arb commentedAug 12, 2015
Changes
momentconstruction to avoid moment deprecation warning.