Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event: Support for `wreck` event from `good` #55

Merged
merged 1 commit into from Nov 5, 2015

Conversation

@krohrsb
Copy link

krohrsb commented Nov 5, 2015

Add support for wreck event from good.
Will output method, url, status and time.
Also supports wreck errors.
Added tests as well keeping 100% coverage.

I did rearrange some (factored out status code and method colorizing) and added some jsdoc comments.

Thanks!

@arb

This comment has been minimized.

Copy link
Contributor

arb commented Nov 5, 2015

I applaud your effort of adding the jsdoc comments, but we aren't using them, so can you please remove them.

@arb arb added the feature label Nov 5, 2015
@arb arb self-assigned this Nov 5, 2015
@krohrsb

This comment has been minimized.

Copy link
Author

krohrsb commented Nov 5, 2015

Sure, no problem. Was more out of habit really. I'll have it updated in a few.

Add support for `wreck` event from `good`.
Will output method, url, status and time.
Also supports wreck errors.
@krohrsb krohrsb force-pushed the krohrsb:feature/wreckEvent branch from 60514a0 to 66a253e Nov 5, 2015
@krohrsb

This comment has been minimized.

Copy link
Author

krohrsb commented Nov 5, 2015

I've updated the PR which excludes those jsdoc comments. Thanks.

@arb arb added this to the 5.2.0 milestone Nov 5, 2015
arb added a commit that referenced this pull request Nov 5, 2015
event: Support for `wreck` event from `good`
@arb arb merged commit 4cc5ec7 into hapijs:master Nov 5, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.