Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upevent: Support for `wreck` event from `good` #55
Conversation
This comment has been minimized.
This comment has been minimized.
|
I applaud your effort of adding the jsdoc comments, but we aren't using them, so can you please remove them. |
This comment has been minimized.
This comment has been minimized.
|
Sure, no problem. Was more out of habit really. I'll have it updated in a few. |
Add support for `wreck` event from `good`. Will output method, url, status and time. Also supports wreck errors.
This comment has been minimized.
This comment has been minimized.
|
I've updated the PR which excludes those jsdoc comments. Thanks. |
arb
added a commit
that referenced
this pull request
Nov 5, 2015
event: Support for `wreck` event from `good`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
krohrsb commentedNov 5, 2015
Add support for
wreckevent fromgood.Will output method, url, status and time.
Also supports wreck errors.
Added tests as well keeping 100% coverage.
I did rearrange some (factored out status code and method colorizing) and added some jsdoc comments.
Thanks!