Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds config option to disable colored output #57

Merged
merged 2 commits into from Jan 22, 2016

Conversation

@jforcada
Copy link
Contributor

jforcada commented Nov 23, 2015

Hi!

This pull request is to be able to deactivate the colored output from the logs. We found very hard to read raw logs from the current output, and also it is pretty hard to search and filter them in tools like kibana.

Hope you like it.

@arb arb self-assigned this Nov 23, 2015
@arb arb added the feature label Nov 23, 2015
@arb arb modified the milestone: 5.3.0 Nov 23, 2015
README.md Outdated
@@ -19,6 +19,7 @@ Creates a new GoodConsole object with the following arguments:
- `[config]` - optional configuration object with the following available keys
- `format` - [MomentJS](http://momentjs.com/docs/#/displaying/format/) format string. Defaults to 'YYMMDD/HHmmss.SSS'.
- `utc` - boolean controlling Moment using [utc mode](http://momentjs.com/docs/#/parsing/utc/) or not. Defaults to `true`.
- `color` - boolean activating the colored output or not. Defaults to `true`.

This comment has been minimized.

Copy link
@AdriVanHoudt

AdriVanHoudt Nov 23, 2015

I would personally phrase it as a boolean specifying whether to output in color (like in the hapi docs)

@jforcada

This comment has been minimized.

Copy link
Contributor Author

jforcada commented Nov 25, 2015

Yes, that's more simple. Corrected.

@AdriVanHoudt

This comment has been minimized.

Copy link

AdriVanHoudt commented Nov 25, 2015

👍

@Marsup

This comment has been minimized.

Copy link
Member

Marsup commented Jan 22, 2016

@arb is this thing going somewhere ?

arb added a commit that referenced this pull request Jan 22, 2016
Adds config option to disable colored output
@arb arb merged commit 391d00c into hapijs:master Jan 22, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.