Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update depedencies and style. Closes #63 Closes #64 #66

Closed
wants to merge 3 commits into from

Conversation

@vdeturckheim
Copy link

vdeturckheim commented Mar 16, 2016

and travis' targets.

- 0.10
- 4
- "4"
- "node"

This comment has been minimized.

Copy link
@AdriVanHoudt

AdriVanHoudt Mar 17, 2016

what does this translate to?
Shouldn't it be "4" "4.0" "5"?

This comment has been minimized.

Copy link
@vdeturckheim

vdeturckheim Mar 17, 2016

Author
  • "4" -> v4.4.0
  • "node" -> v5.8.0

It is the same targets as hapi. I believe it is @arb 's requirement for reporters.

This comment has been minimized.

Copy link
@AdriVanHoudt

AdriVanHoudt Mar 17, 2016

hmm I prefer the more verbose option :P
also hapi does not test on 4.0 anymore? Maybe I dreamt that :D

This comment has been minimized.

This comment has been minimized.

Copy link
@Marsup

Marsup Mar 17, 2016

Member

@AdriVanHoudt hapi's policy is to support LTS and latest stable, that's the only way to make that happen.

This comment has been minimized.

Copy link
@AdriVanHoudt

AdriVanHoudt Mar 17, 2016

ah ok np! must have missed that change :P

@arb

This comment has been minimized.

Copy link
Contributor

arb commented Mar 17, 2016

Most of the string manipulation in here should be replaced with es2015 string templates.


describe('GoodConsole', function () {
describe('GoodConsole', () => {

This comment has been minimized.

Copy link
@arb

arb Mar 17, 2016

Contributor

Please add the plan option to every test.

This comment has been minimized.

Copy link
@vdeturckheim
@arb arb self-assigned this Mar 17, 2016
@arb arb added this to the 6.0.0 milestone Mar 17, 2016
@vdeturckheim

This comment has been minimized.

Copy link
Author

vdeturckheim commented Mar 21, 2016

closing in favor of #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.