Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign uplog event.id when available #80
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Get the tests all passing again, and this looks fine to me. |
This comment has been minimized.
This comment has been minimized.
All set, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mmcgahan commentedDec 7, 2016
This PR is partly for discussion, but it's a feature that we would like to use - adding the
request.id
in therequest
event log from good-console. This makes it much easier to connect therequest.log
calls that correspond to a particular request rather than the 'anonymous' logs that would otherwise be printed.Let me know what you think - we can definitely write our own Good stream/reporter, but I figure this might be generally useful.
Downsides
event.id
with anything other than parens, which might make it lessgrep
ableThoughts?