Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log event.id when available #80

Merged
merged 2 commits into from Dec 8, 2016
Merged

log event.id when available #80

merged 2 commits into from Dec 8, 2016

Conversation

@mmcgahan
Copy link
Contributor

mmcgahan commented Dec 7, 2016

This PR is partly for discussion, but it's a feature that we would like to use - adding the request.id in the request event log from good-console. This makes it much easier to connect the request.log calls that correspond to a particular request rather than the 'anonymous' logs that would otherwise be printed.

Let me know what you think - we can definitely write our own Good stream/reporter, but I figure this might be generally useful.

Downsides

  1. more verbose logging (but not much more verbose)
  2. changing the logging output might break custom log parsers that are tuned to the existing good-console output
  3. the current formatting in this PR doesn't 'tag' the event.id with anything other than parens, which might make it less grepable

Thoughts?

@arb arb added the feature label Dec 8, 2016
@arb arb modified the milestone: 6.2.0 Dec 8, 2016
@arb

This comment has been minimized.

Copy link
Contributor

arb commented Dec 8, 2016

Get the tests all passing again, and this looks fine to me.

@mmcgahan

This comment has been minimized.

Copy link
Contributor Author

mmcgahan commented Dec 8, 2016

All set, thanks.

@arb arb merged commit c8d0de9 into hapijs:master Dec 8, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.