Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separated message and stack with a comma #85

Merged
merged 1 commit into from Feb 8, 2017

Conversation

@travi
Copy link
Contributor

travi commented Feb 3, 2017

this matches the separation in the other formatters and makes it more clear that "stack" is not part of the error message

@arb

This comment has been minimized.

Copy link
Contributor

arb commented Feb 3, 2017

So my issue with this change is that people end up using good-console for more than just writing to the console. They might write to the console, pipe that to a file and then parse the contents. Changing the format might break that parsing logic if we do this. While I agree with this change in principle, it's been like this for several years and this is the first PR trying to make this change.

@travi

This comment has been minimized.

Copy link
Contributor Author

travi commented Feb 3, 2017

i can see that it could be a breaking change depending on usage by some. would it at least make sense to include in the next major release where the version would communicate that there are some breaking changes?

@arb arb modified the milestone: 6.4.0 Feb 5, 2017
@arb arb self-assigned this Feb 5, 2017
@arb arb modified the milestone: 6.4.0 Feb 5, 2017
@arb

This comment has been minimized.

Copy link
Contributor

arb commented Feb 5, 2017

Can you update the readme with this formatting change?

this matches the separation in the other formatters and makes it more clear that "stack" is not part of the error message
@travi travi force-pushed the travi:error-format branch from f5ef83e to 3fea72a Feb 6, 2017
@travi

This comment has been minimized.

Copy link
Contributor Author

travi commented Feb 6, 2017

good call. updated

@arb arb merged commit 729155b into hapijs:master Feb 8, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@travi travi deleted the travi:error-format branch Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.