Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log all request headers with extended requests #104

Closed
geek opened this issue Dec 19, 2013 · 7 comments
Closed

Log all request headers with extended requests #104

geek opened this issue Dec 19, 2013 · 7 comments
Assignees
Labels
Milestone

Comments

@geek
Copy link
Member

@geek geek commented Dec 19, 2013

Ensure that all request headers are logged with the request event data.

@hueniverse

This comment has been minimized.

Copy link
Member

@hueniverse hueniverse commented Dec 19, 2013

Is this a debug feature? /cc @kpdecker

@kpdecker

This comment has been minimized.

Copy link

@kpdecker kpdecker commented Dec 20, 2013

Yes. Logging the headers allows us to examine logs across the different tiers of the system and across requests as session information can be used to correlate the different sources.

This could easily be implemented via custom code but our previous chats I was under the impression that this was intended for good and the implementation was missed.

@hueniverse

This comment has been minimized.

Copy link
Member

@hueniverse hueniverse commented Dec 20, 2013

If this is meant for debugging, we can just dump the headers object. Otherwise, I'd like to see some filters to avoid turning the logs into junkyard.

@kpdecker

This comment has been minimized.

Copy link

@kpdecker kpdecker commented Dec 20, 2013

This is intended for debugging production, so yes there could easily be a lot of data pushed through here. For the near term we can easily track the few headers we want directly.

@joshua-mcginnis

This comment has been minimized.

Copy link

@joshua-mcginnis joshua-mcginnis commented Mar 17, 2014

+1 We had to write a plugin to do this. It grabs the headers onPreHandler and makes an added log call which adds the headers to the logs.

request.log('detail', headers);

@a-c-m

This comment has been minimized.

Copy link

@a-c-m a-c-m commented Apr 24, 2014

@joshua-mcginnis have you released that plugin anywhere? I couldn't see it on your github profile.

@lloydbenson

This comment has been minimized.

Copy link
Contributor

@lloydbenson lloydbenson commented Aug 29, 2014

Is this properly addressed with 1d2eee8?

@geek geek closed this Aug 29, 2014
@geek geek added this to the 2.3.0 milestone Aug 29, 2014
@geek geek self-assigned this Aug 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.