Skip to content

/good

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple good-file #210

Closed
arb opened this issue Oct 16, 2014 · 0 comments · Fixed by #239
Closed

Decouple good-file #210

arb opened this issue Oct 16, 2014 · 0 comments · Fixed by #239
Assignees
@arb
Labels
breaking changes dependency
Milestone
4.0.0

Comments

@arb
Copy link
Contributor

@arb arb commented Oct 16, 2014

The coupling of good-file makes it difficult to make changes that won't also impact people currently using good. If you want good-file, you should require it the same as every other reporter.
@arb arb added this to the 4.0.0 milestone Oct 16, 2014
@arb arb added the new contributor label Oct 16, 2014
@arb arb removed this from the 4.0.0 milestone Oct 16, 2014
@arb arb removed the new contributor label Oct 16, 2014
@arb arb added this to the 4.0.0 milestone Oct 31, 2014
@arb arb self-assigned this Oct 31, 2014
This was referenced Oct 31, 2014
Closed
Merged
@cjihrig cjihrig closed this in #239 Nov 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arb arb

Labels
breaking changes dependency
Projects
None yet
Milestone
  4.0.0
1 participant
@arb
You can’t perform that action at this time.