Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change event names #223

Closed
arb opened this issue Oct 24, 2014 · 1 comment · Fixed by #267
Closed

Change event names #223

arb opened this issue Oct 24, 2014 · 1 comment · Fixed by #267
Assignees
Milestone

Comments

@arb
Copy link
Contributor

@arb arb commented Oct 24, 2014

Rename request to be response because that is more appropriate because the corresponding hapi events are "tail" and "response". This will free up request to be used for request.log events.

@arb

This comment has been minimized.

Copy link
Contributor Author

@arb arb commented Oct 31, 2014

This is going to take a little more work because the default event in good-reporter is "request" so this will have a cascading impact.

@arb arb modified the milestone: 5.0.0 Nov 24, 2014
@arb arb self-assigned this Nov 24, 2014
This was referenced Nov 24, 2014
@geek geek closed this in #267 Dec 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.