Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Up Process #237

Closed
arb opened this issue Nov 3, 2014 · 2 comments · Fixed by #240
Closed

Clean Up Process #237

arb opened this issue Nov 3, 2014 · 2 comments · Fixed by #240
Labels
Milestone

Comments

@arb
Copy link
Contributor

@arb arb commented Nov 3, 2014

The code in lib/utils inheritAsync is a little suspect. It should be cleaned up. It's also related to #236 because we are interacting with "stdin" on an object that gets passed into this function.

@arb arb added this to the 4.0.0 milestone Nov 3, 2014
@arb arb added bug feature labels Nov 3, 2014
@chriswiggins

This comment has been minimized.

Copy link

@chriswiggins chriswiggins commented Nov 3, 2014

@arb, what can I / we do to fix this?

@arb

This comment has been minimized.

Copy link
Contributor Author

@arb arb commented Nov 4, 2014

Well the whole thing needs to be cleaned up. The biggest issue is the dynamic addition of function to the prototype here https://github.com/hapijs/good/blob/master/lib/utils.js#L17-L31. This should probably be refactored to just return a real JavaScript object with methods attached to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.