Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Standard Event #251

Closed
arb opened this issue Nov 10, 2014 · 0 comments · Fixed by #283
Closed

Create Standard Event #251

arb opened this issue Nov 10, 2014 · 0 comments · Fixed by #283
Assignees
Labels
Milestone

Comments

@arb
Copy link
Contributor

@arb arb commented Nov 10, 2014

When the "report" event is emitted, a standard object should be passed into the handler. That way, there is some contract between the emitter and the reporter. This will also provide better visibility into mdb if we ever need to debug.

The event should have event as a string and payload or data and that should be the contents of the event. It would also be prudent to overwrite the toJSON method to make sure circular objects are handled properly. Then the reporters would not need to worry about that.

The object should be called "goody" in keeping with the fun names.

@arb arb modified the milestone: 5.1.0 Dec 18, 2014
@arb arb self-assigned this Dec 18, 2014
arb added a commit to arb/good that referenced this issue Dec 18, 2014
@arb arb mentioned this issue Dec 18, 2014
@geek geek closed this in #283 Dec 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.