Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Options #299

Closed
arb opened this issue Feb 4, 2015 · 1 comment · Fixed by #310
Closed

Rename Options #299

arb opened this issue Feb 4, 2015 · 1 comment · Fixed by #310
Assignees
Milestone

Comments

@arb
Copy link
Contributor

@arb arb commented Feb 4, 2015

Rename logRequestHeaders, logRequestPayload, logResponsePayload because setting them only includes those values in the data passed into the different reporters and it creates confusion.

@arb arb added the breaking changes label Feb 4, 2015
@arb arb added this to the 6.0.0 milestone Feb 4, 2015
@arb arb added the feature label Feb 4, 2015
@shaunbruno

This comment has been minimized.

Copy link

@shaunbruno shaunbruno commented Mar 9, 2015

Agreed. Ideally, the reporters should respect those options. Prior to seeing this I opened an issue under good-console:
hapijs/good-console#36

Alternatively, those options could be per-reporter, which would give some flexibility as to how each interprets the options. But as it stands, the flags are misleading.

@arb arb self-assigned this Mar 9, 2015
arb added a commit to arb/good that referenced this issue Mar 9, 2015
@arb arb mentioned this issue Mar 9, 2015
@arb arb closed this in #310 Mar 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.