Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Up Stop #312

Closed
arb opened this issue Mar 12, 2015 · 3 comments · Fixed by #321
Closed

Clean Up Stop #312

arb opened this issue Mar 12, 2015 · 3 comments · Fixed by #321
Labels
Milestone

Comments

@arb
Copy link
Contributor

@arb arb commented Mar 12, 2015

Do we really need to remove the event handlers? The only time stop is called is when the hapi server emits the "stop" event and means the node process is probably about to end.

@arb arb added the feature label Mar 12, 2015
@arb arb added this to the 6.0.0 milestone Mar 12, 2015
@Marsup

This comment has been minimized.

Copy link
Member

@Marsup Marsup commented Mar 12, 2015

Nope, it can happen multiple times in tests, and there's nothing preventing someone from spawning temporary servers for whatever reason.

@arb

This comment has been minimized.

Copy link
Contributor Author

@arb arb commented Mar 12, 2015

So we need to keep all that annoying logic to remove the event listeners? Why?

@Marsup

This comment has been minimized.

Copy link
Member

@Marsup Marsup commented Mar 12, 2015

Well you can probably keep them if you have zero chance to receive any. Did you ever make tests to see if losing any reference to a stopped hapi server GCs it ?

arb added a commit to arb/good that referenced this issue Apr 2, 2015
@geek geek closed this in #321 Apr 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.