Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Log Headers Options #336

Closed
arb opened this issue Apr 22, 2015 · 3 comments
Closed

Change Log Headers Options #336

arb opened this issue Apr 22, 2015 · 3 comments
Assignees
Milestone

Comments

@arb
Copy link
Contributor

@arb arb commented Apr 22, 2015

With more headers and payloads being added via the "wreck" event, the includeRequestPayload type options are becoming a little cumbersome to work with. We need a more maintainable way to control what is sent out from good.

@arb arb added example labels Apr 22, 2015
@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

@AdriVanHoudt AdriVanHoudt commented Apr 23, 2015

A master option and an option per event type?

@arb

This comment has been minimized.

Copy link
Contributor Author

@arb arb commented Apr 23, 2015

I want less options and I think that route will just add more.

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

@AdriVanHoudt AdriVanHoudt commented Apr 23, 2015

Less options will be better idd. How about a 'payload' option where you define the events it's appliable on? like includeHeaders: ['wreck', 'response'] or includeHeaders: 'response' ?

@arb arb added feature and removed example labels Apr 23, 2015
@arb arb modified the milestone: 6.5.0 Oct 25, 2015
@arb arb modified the milestone: 7.0.0 Nov 18, 2015
@arb arb self-assigned this Mar 1, 2016
arb added a commit that referenced this issue Mar 2, 2016
Closes #336
- Update options to use "include" which is an array of strings
- Currently only supports ['requestHeaders','requestPayload', 'responsePayload']
@arb arb closed this in 1afb0c9 Mar 2, 2016
arb added a commit that referenced this issue Mar 2, 2016
Closes #336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.