Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug when filter is used #337

Closed
dvic opened this issue Apr 25, 2015 · 0 comments · Fixed by #338
Closed

bug when filter is used #337

dvic opened this issue Apr 25, 2015 · 0 comments · Fixed by #338
Labels
bug
Milestone

Comments

@dvic
Copy link
Contributor

@dvic dvic commented Apr 25, 2015

I'm getting the following error for GET requests when applying a filter:

Debug: internal, implementation, error
    TypeError: Cannot read property 'key' of undefined
    at Object.<anonymous> (/Users/damirv/hapi/node_modules/good/lib/utils.js:93:69)
    at walker (/Users/damirv/hapi/node_modules/good/node_modules/traverse/index.js:190:22)
    at walk (/Users/damirv/hapi/node_modules/good/node_modules/traverse/index.js:226:7)
    at Traverse.forEach (/Users/damirv/hapi/node_modules/good/node_modules/traverse/index.js:50:18)
    at applyFilter (/Users/damirv/hapi/node_modules/good/lib/utils.js:90:24)
    at new exports.GreatResponse (/Users/damirv/hapi/node_modules/good/lib/utils.js:146:9)
    at Object.exports.GreatResponse (/Users/damirv/hapi/node_modules/good/lib/utils.js:77:16)
    at internals.Monitor._responseHandler (/Users/damirv/hapi/node_modules/good/lib/monitor.js:230:33)
    at emit (events.js:95:17)
    at handler (/Users/damirv/hapi/node_modules/hapi/node_modules/kilt/lib/index.js:54:44)

I've set up a sample app that shows this problem: https://github.com/damirv/hapi-good-filter-bug.

Am I missing something or this a bug? It seems that applyFilter is being passed null for data.

@arb arb added the bug label Apr 26, 2015
@arb arb added this to the 6.1.2 milestone Apr 26, 2015
@arb arb closed this in #338 Apr 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.