Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull ops event out #392

Closed
arb opened this issue Oct 12, 2015 · 4 comments
Closed

Pull ops event out #392

arb opened this issue Oct 12, 2015 · 4 comments

Comments

@arb
Copy link
Contributor

@arb arb commented Oct 12, 2015

I'd like to remove the "ops" event logic and emitting from the internals of Good. I'd like to make use of the Ops event in a new module, but I don't need the baggage of the rest of Good.

@arb arb added the question label Oct 12, 2015
@fhemberger

This comment has been minimized.

Copy link
Contributor

@fhemberger fhemberger commented Oct 25, 2015

Is this feature even widely used? I think many projects are already using unified monitoring tools throughout their whole stack that cover the same metrics that the "ops" event provides.

As logs and metrics are a slightly different concern anyways, it might make sense to split them into a different module.

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

@AdriVanHoudt AdriVanHoudt commented Oct 26, 2015

I only use it to monitor stuff in dev

@savardc

This comment has been minimized.

Copy link

@savardc savardc commented Oct 26, 2015

Agree, it's nice to have for dev but I don't think it needs to be part of Good

@arb

This comment has been minimized.

Copy link
Contributor Author

@arb arb commented Nov 17, 2015

Check out Oppsy hapijs/oppsy#1

@arb arb modified the milestone: 7.0.0 Nov 18, 2015
arb added a commit to arb/good that referenced this issue Nov 18, 2015
- Use the Oppsy object
- Remove all the ops collecting code and tests
- Updated API to reflect change
- Update tests
arb added a commit that referenced this issue Nov 18, 2015
Moved to use Oppsy. Closes #392.
@arb arb closed this Nov 20, 2015
arb added a commit that referenced this issue Mar 1, 2016
- Use the Oppsy object
- Remove all the ops collecting code and tests
- Updated API to reflect change
- Update tests
@Marsup Marsup added support and removed question labels Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.