Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No httpVersion when monitoring response #410

Closed
hostiphur opened this issue Nov 23, 2015 · 0 comments
Closed

No httpVersion when monitoring response #410

hostiphur opened this issue Nov 23, 2015 · 0 comments
Milestone

Comments

@hostiphur
Copy link
Contributor

@hostiphur hostiphur commented Nov 23, 2015

I'm trying to create a custom reporter in order to output logs in the Apache Combined Log format. However, I'm not seeing any way to get access to the HTTP Version. In node this is easily accessed via request.raw.req.httpVersion. I've been looking through Good's source code and it seems this could easily be fixed by passing that value along with GreatResponse. Ideally the whole raw object could be passed along.

I found another project where someone is having the exact same trouble as me. Is a fix necessary or are we simply not looking in the correct place for this info?

The other project I referenced: https://github.com/jhs/good-apache-log

@arb arb modified the milestone: 6.5.0 Feb 4, 2016
@arb arb closed this in 501709a Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.