Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Event #415

Closed
arb opened this issue Dec 4, 2015 · 0 comments
Closed

Stop Event #415

arb opened this issue Dec 4, 2015 · 0 comments
Milestone

Comments

@arb
Copy link
Contributor

@arb arb commented Dec 4, 2015

Don't emit the "stop" event. It's confusing and there will be a better way to tear down. Also, pushing null into the stream will signify the end of writing so reporter streams can just use that instead.

@arb arb added the breaking changes label Dec 4, 2015
@arb arb added this to the 7.0.0 milestone Dec 4, 2015
arb added a commit to arb/good that referenced this issue Dec 8, 2015
@arb arb mentioned this issue Dec 8, 2015
@arb arb closed this Dec 8, 2015
arb added a commit that referenced this issue Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.