Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document `good` Route and Reply Config #472

Closed
arb opened this issue Apr 19, 2016 · 2 comments
Closed

Document `good` Route and Reply Config #472

arb opened this issue Apr 19, 2016 · 2 comments
Labels
Milestone

Comments

@arb
Copy link
Contributor

@arb arb commented Apr 19, 2016

Good will not attach route.plugin.good and request.plugin.good objects to all of the events that have request available. Include this in the docs and mention how you can use this for additional filtering logic.

See this test for an example.

@arb arb added this to the 7.0.0 milestone Apr 19, 2016
@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

@AdriVanHoudt AdriVanHoudt commented Apr 20, 2016

wait so the point is you have manually set request.plugin.good ? I have not played around with good 7 so not sure what is going on :P

@arb

This comment has been minimized.

Copy link
Contributor Author

@arb arb commented Apr 20, 2016

You don't have to do anything. This is just a way you can pass route or request level config options into good if you want to. I imagine people using this for additional filtering rules.

@arb arb closed this in a56490b Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.