Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hapi v17 support #568

Closed
hueniverse opened this issue Nov 4, 2017 · 19 comments
Closed

hapi v17 support #568

hueniverse opened this issue Nov 4, 2017 · 19 comments

Comments

@hueniverse
Copy link
Member

@hueniverse hueniverse commented Nov 4, 2017

What's the plan? Migrate? Deprecate?

@arb

This comment has been minimized.

Copy link
Contributor

@arb arb commented Nov 4, 2017

Migration shouldn't be difficult but I really don't have the time to change the reporting interface again. I didn't get a strong opinion either way in the slack about deprecating good or not. The npm downloads, which I realize aren't a perfect metric, is in the thousands per day so people must be using it.

@corbinu

This comment has been minimized.

Copy link
Contributor

@corbinu corbinu commented Nov 4, 2017

I am using it but would be open to transition what would the plan be to migrate to? Winston or something else?

@alexandrebodin alexandrebodin mentioned this issue Nov 6, 2017
0 of 3 tasks complete
@BorntraegerMarc

This comment has been minimized.

Copy link

@BorntraegerMarc BorntraegerMarc commented Nov 6, 2017

@arb is there an ETA when we could expect an update? Now that hapi v17 final has been released 😄

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

@AdriVanHoudt AdriVanHoudt commented Nov 8, 2017

If you want v17 support for this the best way is to submit a PR ;)

@PizzaBrandon

This comment has been minimized.

Copy link

@PizzaBrandon PizzaBrandon commented Nov 8, 2017

I like good and want it to survive. I'll take a crack at this and see what I can do, but I also encourage others to take up the cause, too.

If good is deprecated, what (if anything) is its replacement?

@g-corneu

This comment has been minimized.

Copy link

@g-corneu g-corneu commented Nov 9, 2017

I quite like and am currently using good. I'll have a stab at migrating and opening a PR. 😄

@corbinu

This comment has been minimized.

Copy link
Contributor

@corbinu corbinu commented Nov 15, 2017

@g-corneu Any luck? Otherwise I will take a stab also

@g-corneu

This comment has been minimized.

Copy link

@g-corneu g-corneu commented Nov 15, 2017

@corbinu I'm finishing up porting oppsy and am hoping to open a PR for that in the next couple of days since good depends on it. I'll move on to porting good after that; should be able to spend some dedicated time on it this weekend + first 2 days of next week. Happy to work together if you're interested and free.

@corbinu

This comment has been minimized.

Copy link
Contributor

@corbinu corbinu commented Nov 27, 2017

@g-corneu I finally had some time now that it is after Black Friday. I have a version of oppsy that is ready to go and have made some progress on good. Would be happy to sync up if you like.

@g-corneu

This comment has been minimized.

Copy link

@g-corneu g-corneu commented Nov 27, 2017

@corbinu

This comment has been minimized.

Copy link
Contributor

@corbinu corbinu commented Nov 27, 2017

No worries TOTALLY know that feeling good luck!

Will do thanks mostly now just doing more upgrades to node 8 syntax rather than just getting them working.

@lostthetrail

This comment has been minimized.

Copy link
Contributor

@lostthetrail lostthetrail commented Dec 1, 2017

@arb @hueniverse My understanding was that Good was the standard logging plugin for Hapi.js. What are y'all using that makes Good a potential target for deprecation?

@hueniverse

This comment has been minimized.

Copy link
Member Author

@hueniverse hueniverse commented Dec 1, 2017

@lostthetrail people use a bunch of different solutions. I use my own.

@framerate

This comment has been minimized.

Copy link

@framerate framerate commented Dec 7, 2017

@lostthetrail people use a bunch of different solutions. I use my own.

Do you have any examples? I've been using good for a few years now and would love to investigate some v17 compatible alternatives!

@corbinu

This comment has been minimized.

Copy link
Contributor

@corbinu corbinu commented Dec 7, 2017

Just an update I am digging through the last few issues and waiting for release of my oppsy update. Hoping to have a PR up in the next few days. Work just keeps getting in my way.

@corbinu

This comment has been minimized.

Copy link
Contributor

@corbinu corbinu commented Dec 7, 2017

Pushed up my progress here: https://github.com/corbinu/good

Turned out some of the errors are just that goods current test suite fails on OS X. It is green on Linux now.

However I am getting an warning from node: "Possible EventEmitter memory leak detected. 11 end listeners added. Use emitter.setMaxListeners() to increase limit"

It does drop support for Wreck logging as the global events were removed in the most recent versions of Wreck.

Feel free to try it out and give feedback!

@framerate

This comment has been minimized.

Copy link

@framerate framerate commented Dec 7, 2017

@corbinu I set it up in its most basic form and I have route logging printing now, so far so good!

@fhemberger

This comment has been minimized.

Copy link
Contributor

@fhemberger fhemberger commented Dec 14, 2017

@framerate For simple logging I switched to bunyan (using hapi-bunny). As I mostly run containerized Node.js applications these days, I only need to log to stdout/stderr. Ops related stats are handled by Docker or Prometheus (https://github.com/siimon/prom-client).

@arb arb added this to the 8.0.0-rc1 milestone Dec 20, 2017
@arb

This comment has been minimized.

Copy link
Contributor

@arb arb commented Dec 21, 2017

Closed via #572

@arb arb closed this Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.