Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Good 8.0.0 Release Notes #575

Closed
arb opened this issue Jan 2, 2018 · 4 comments
Closed

Good 8.0.0 Release Notes #575

arb opened this issue Jan 2, 2018 · 4 comments
Assignees
Milestone

Comments

@arb
Copy link
Contributor

@arb arb commented Jan 2, 2018

⚠️ This doc may change slightly as this is for a release candidate. Important changes will be called out in the document comments. This issue will remain open until version 8 has been published. ⚠️

Install with npm i good@8.0.0-rc1

Summary

The goal of the 8.0.0 release was to migrate to the newest version of node as well as the latest version of hapi and cut support for all previous versions.

There are no public facing API changes.

  • Upgrade time: low - You should just need the new version of good since you probably already upgraded hapi and node.
  • Complexity: low - change your options and your version of hapi.
  • Risk: moderate - as a major bump, there is always an amount of risk.
  • Dependencies: low - just major bumps on all the hapi modules

Breaking Changes

  • It's noted in package.json, but it's worth repeating here: good is only compatible with node >= 8.00 and hapi >= 17.0.0
  • RequestSent lost the responseSentTime property
  • RequestSent.responseTime was changed to be the calculation of request.info.responded - request.info.received

Updated Dependencies

  • hoek
  • joi
  • oppsy

Contributors

Special thanks to @corbinu for the bulk of the node migration!

@arb arb added this to the 8.0.0-rc1 milestone Jan 2, 2018
@arb arb self-assigned this Jan 2, 2018
@arb arb removed this from the 8.0.0-rc1 milestone Jan 2, 2018
@v1r

This comment has been minimized.

Copy link

@v1r v1r commented Jan 14, 2018

Hi there! Do we have a release date for v8.0.0 in npm that supports Hapi v17 ? Thank you!

@arb

This comment has been minimized.

Copy link
Contributor Author

@arb arb commented Jan 16, 2018

Do you mean 8.0.0? You can start using it today by installing the release candidate.

@sholladay

This comment has been minimized.

Copy link

@sholladay sholladay commented Jan 27, 2018

Bug / documentation issue with the RC's README: using the usage example, I see this for each request... (responseSentTime: undefinedms)

@arb

This comment has been minimized.

Copy link
Contributor Author

@arb arb commented Jan 29, 2018

@sholladay that's actually a problem in good-console. Please see the related issue.

@arb arb added this to the 8.0.0 milestone Jan 29, 2018
@arb arb closed this Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.