Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add status code with color for console output #109

Merged
merged 3 commits into from Mar 13, 2014

Conversation

@oliverzy
Copy link
Contributor

oliverzy commented Jan 13, 2014

Express logger has a feature that can display response status code with different color like red, cyan, green.
It's useful to quickly identify error response from the console.

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Jan 14, 2014

Fails tests. Also, does 'colors' changes prototype? We don't allow those modules.

@oliverzy

This comment has been minimized.

Copy link
Contributor Author

oliverzy commented Jan 14, 2014

Okay, I removed colors dependency and fix the failed test. Please review again.

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Jan 14, 2014

lib/monitor.js missing coverage on line(s): 534

@oliverzy

This comment has been minimized.

Copy link
Contributor Author

oliverzy commented Jan 14, 2014

done, thanks

@hueniverse hueniverse added this to the 2.0.0 milestone Mar 13, 2014
@hueniverse hueniverse self-assigned this Mar 13, 2014
hueniverse added a commit that referenced this pull request Mar 13, 2014
add status code with color for console output
@hueniverse hueniverse merged commit f19a0f1 into hapijs:master Mar 13, 2014
hueniverse added a commit that referenced this pull request Mar 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.