Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis logging #110

Merged
merged 2 commits into from Mar 13, 2014
Merged

redis logging #110

merged 2 commits into from Mar 13, 2014

Conversation

@andyroyle
Copy link
Contributor

andyroyle commented Jan 24, 2014

Adds support for logging to a redis instance (using RPUSH).

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Jan 25, 2014

Interesting. Let me think about it. I am worried about the extra deps mostly but not too much.

@jmonster

This comment has been minimized.

Copy link

jmonster commented Feb 11, 2014

Adding redis support is a no brainer But what about making it optional -- if you attempt to use the redis logger without manually adding node-redis to your project then it will emit an explicit error (similar to joi validation errors in Hapi configuration) while those who don't opt for redis logging won't be affected at all.

This would be similar to how node-redis itself works, where it attempts to leverage hiredis when it's available (you must explicitly add it to your project) but transparently falls back to the javascript implementation otherwise.

@andyroyle

This comment has been minimized.

Copy link
Contributor Author

andyroyle commented Feb 11, 2014

This sounds like a good idea to me

@hueniverse hueniverse added this to the 2.0.0 milestone Mar 13, 2014
@hueniverse hueniverse self-assigned this Mar 13, 2014
hueniverse added a commit that referenced this pull request Mar 13, 2014
@hueniverse hueniverse merged commit a699c3b into hapijs:master Mar 13, 2014
hueniverse added a commit that referenced this pull request Mar 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.