Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug to ensure port is defined #119

Closed
wants to merge 1 commit into from

Conversation

@joshua-mcginnis
Copy link

joshua-mcginnis commented Mar 8, 2014

We're deploying our apps in a Windows environment where we have named pipes as hosts and ports are undefined.

This particular bug was causing Good to throw errors for some of our apps. This appears to resolve the issue.

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Mar 13, 2014

Thanks. I fixed it as a side effect of coverage work.

@hueniverse hueniverse closed this Mar 13, 2014
@hueniverse hueniverse added the bug label Mar 13, 2014
@hueniverse hueniverse added this to the 2.0.0 milestone Mar 13, 2014
@hueniverse hueniverse self-assigned this Mar 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.