Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify extra fields #132

Merged
merged 5 commits into from Aug 19, 2014
Merged

Specify extra fields #132

merged 5 commits into from Aug 19, 2014

Conversation

@andyroyle
Copy link
Contributor

andyroyle commented Apr 3, 2014

When using centralised logging it is sometimes necessary to include extra fields on the envelope (types, identifiers etc).

This allows you to specify some constant fields that will get added to the envelope before broadcasting.

@jameswyse

This comment has been minimized.

Copy link

jameswyse commented Apr 22, 2014

👍 I need to include the name, version, etc of the application in the log entry so I can filter them in Kibana

@@ -241,6 +242,22 @@ internals.Monitor.prototype._broadcastRemotes = function () {
};


internals.Monitor.prototype._makeEnvelope = function(subscriberQueue, uri){

This comment has been minimized.

Copy link
@geek

geek May 27, 2014

Member

Please fix the style:

internals.Monitor.prototype._makeEnvelope = function (subscriberQueue, uri) {
@@ -241,6 +242,22 @@ internals.Monitor.prototype._broadcastRemotes = function () {
};


internals.Monitor.prototype._makeEnvelope = function(subscriberQueue, uri){
var self = this;

This comment has been minimized.

Copy link
@geek

geek May 27, 2014

Member

Please add a newline after functions

@andyroyle

This comment has been minimized.

Copy link
Contributor Author

andyroyle commented May 28, 2014

fixed the style as requested, also rebased onto the current head of master

@arb arb added this to the 2.2.3 milestone Aug 19, 2014
@arb arb added the enhancement label Aug 19, 2014
@arb

This comment has been minimized.

Copy link
Contributor

arb commented Aug 19, 2014

@andyroyle please check the Travis build. There are several tests currently failing.

@lloydbenson lloydbenson modified the milestones: 2.2.3, 2.3.0 Aug 19, 2014
@andyroyle

This comment has been minimized.

Copy link
Contributor Author

andyroyle commented Aug 19, 2014

wow, totally forgot about this. I've rebased and fixed the failing test

@andyroyle

This comment has been minimized.

Copy link
Contributor Author

andyroyle commented Aug 19, 2014

so I can't reproduce this build failure locally, not sure why it's failing. I'm using node v0.10.30 and npm 1.4.21 (same as the travis agent)

arb added a commit that referenced this pull request Aug 19, 2014
@arb arb merged commit 590c440 into hapijs:master Aug 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.