Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow all request headers to be optionally logged #140

Closed
wants to merge 1 commit into from

Conversation

@stevejhiggs
Copy link
Contributor

stevejhiggs commented May 28, 2014

Sometimes the only way to fully know what a request did is to also log all the headers. With this in place I can fully simulate the original request.

@geek

This comment has been minimized.

Copy link
Member

geek commented Aug 12, 2014

@stevejhiggs and @lloydbenson thoughts on logging the request headers when extendedRequests is true?

@lloydbenson

This comment has been minimized.

Copy link
Contributor

lloydbenson commented Aug 12, 2014

I don't think that would be a bad default, though it seems like maybe you could pass it an object which lets you do just specific portions of it. If we wanted extendedRequests to do a ton of stuff by default. This way you only log what you need if you want to get rid of potions of that logging. So maybe extendedRequests is just a default setting, and you can be more specific with how you'd like it to behave?

@@ -33,6 +33,7 @@ set `options` to an object with the following optional settings:
The subscriptions that are available are _ops_, _request_, _log_ and _error_. The destination can be a URI, file or directory path, and _console_.
Defaults to a console subscriber for _ops_, _request_, and _log_ events. To disable the console output for the server instance pass an empty array
into the subscribers "console" configuration.
- `logAllRequestHeaders` - determines if all request headers will be logged. Defaults to _false_

This comment has been minimized.

Copy link
@geek

geek Aug 12, 2014

Member

can we rename to be shorter: logRequestHeaders

@arb arb added this to the 2.2.3 milestone Aug 19, 2014
@arb arb added the enhancement label Aug 19, 2014
@arb

This comment has been minimized.

Copy link
Contributor

arb commented Aug 19, 2014

This PR is missing tests and the build is currently failing here.

@lloydbenson lloydbenson modified the milestones: 2.2.3, 2.3.0 Aug 19, 2014
@andyroyle andyroyle mentioned this pull request Aug 19, 2014
@arb

This comment has been minimized.

Copy link
Contributor

arb commented Aug 19, 2014

Trumped by #172

@arb arb closed this Aug 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.