Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console cleanup #195

Merged
merged 4 commits into from Oct 7, 2014
Merged

Console cleanup #195

merged 4 commits into from Oct 7, 2014

Conversation

@arb
Copy link
Contributor

arb commented Sep 25, 2014

Fixes #189

  • Use util for string formatting
  • Switched to moment for date formatting
  • Added test for date formatting

Moment has been sort of "approved for use" as seen here

@arb arb added this to the 3.0.0 milestone Sep 25, 2014
@arb arb assigned geek Sep 25, 2014
}

internals.printEvent({
timestamp: event.timestamp,
tags: ['request'],
data: event.instance + ': ' + method + ' ' + event.path + ' ' + query + statusCode + ' (' + event.responseTime + 'ms)' + responsePayload
//instance, method, path, query, statusCode, responseTime, responsePayload
data: Util.format('%s: %s %s %s %s (%sms) %s', event.instance, method, event.path, query, statusCode, event.responseTime, responsePayload)

This comment has been minimized.

Copy link
@geek

geek Oct 3, 2014

Member

It may be worth adding format to Hoek, the same where inherits is added.

@geek geek added the feature label Oct 3, 2014
@geek

This comment has been minimized.

Copy link
Member

geek commented Oct 3, 2014

The test for this change fails

@arb

This comment has been minimized.

Copy link
Contributor Author

arb commented Oct 6, 2014

Should be G2G now @geek. Got foiled by East Coast/West Coast timezone battle.

@cjihrig cjihrig assigned cjihrig and unassigned geek Oct 7, 2014
cjihrig added a commit that referenced this pull request Oct 7, 2014
@cjihrig cjihrig merged commit f974ed3 into hapijs:v3.0.0 Oct 7, 2014
@arb arb deleted the arb:console-cleanup branch Apr 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.