Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added socket information. #213

Merged
merged 2 commits into from Oct 22, 2014
Merged

Added socket information. #213

merged 2 commits into from Oct 22, 2014

Conversation

@arb
Copy link
Contributor

arb commented Oct 17, 2014

Closes #180

Adds sockets key under load key that looks something like this

{
  "sockets":{
    "http":{
      "total":5,
      "www.google.com:80":5
    },
    "https":{
      "total":5,
      "www.google.com:443":5
    }
  }
}

In order to have a remote chance of properly tracing this, users need to supply a list of agents they want statistics on. For most people, it will be the global http and https agents. But the new httpAgents and httpsAgents are there in case you use something else.

Paging Dr. @lloydbenson in case you want to look this before it gets merged in.

@arb arb added the feature label Oct 17, 2014
@arb arb added this to the 3.1.0 milestone Oct 17, 2014
@arb arb assigned geek Oct 17, 2014
@@ -8,7 +8,7 @@ var internals = {};
exports.assert = function (type, options) {

var error = Joi.validate(options, internals[type]).error;
Hoek.assert(!error, 'Invalid', type, 'options', error && error.annotate());

This comment has been minimized.

Copy link
@arb

arb Oct 17, 2014

Author Contributor

I had to drop annotate() here because it chokes on the http.Agent object due to circular references.

geek added a commit that referenced this pull request Oct 22, 2014
@geek geek merged commit 0119d77 into hapijs:master Oct 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.