Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose #216

Merged
merged 3 commits into from Oct 21, 2014
Merged

Compose #216

merged 3 commits into from Oct 21, 2014

Conversation

@arb
Copy link
Contributor

arb commented Oct 21, 2014

Closes #208

You can now pass a string is the reporter option. This should allow Pack.compose to work again.

@arb arb added this to the 3.1.0 milestone Oct 21, 2014
@arb arb assigned geek Oct 21, 2014
@arb arb force-pushed the arb:compose branch from dd029cc to cc135a4 Oct 21, 2014
@arb arb force-pushed the arb:compose branch from cc135a4 to c90c1fd Oct 21, 2014
@geek geek added the feature label Oct 21, 2014
README.md Outdated
- `reporter` - a constructor function generally via `require`, ie `require('good-file')`
- `reporter` - indicates the reporter object to create. Can be one of two values
- a constructor function generally via `require`, ie `require('good-file')`
- a module name to `require`. Uses the built in Node `require` function so you can pass a module name or a path. The supplied module must implement to good-reporter interface. Note: if you want the built in console reporter, pass "good-console".

This comment has been minimized.

Copy link
@geek

geek Oct 21, 2014

Member

typo: to -> the
built in -> built-in

geek added a commit that referenced this pull request Oct 21, 2014
@geek geek merged commit 9c42ad2 into hapijs:master Oct 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.