provided option to use x-forwarded-for as remote address [updated]

[midnightcodr]

Providing the option to use X-Forwarded-For as remote client's ip address can be very useful when hapi serves behind nginx or a load balancing web server. It makes more sense to record the 'true' remote ip instead of the proxy server's ip in that kind of scenario.

[arb]

Would there ever be a time where you wouldn't want this? If not, rather than adding another option, why not just always log this value and if that header isn't set, it'll be undefined and will come out in the wash when it's stringified.

[midnightcodr]

If x-forwarde-for is not in the header remoteAddress will fall back to request.info.remoteAddress. Also I would love to be able get x-forwarde-for logged without adding another option. Could you clarify "always log this value"? Can it be done without modifying the code? Thanks.

Sent from my iPhone

On Oct 30, 2014, at 5:27 PM, Adam Bretz notifications@github.com wrote:

Would there ever be a time where you wouldn't want this? If not, rather than adding another option, why not just always log this value and if that header isn't set, it'll be undefined and will come out in the wash when it's stringified.

—
Reply to this email directly or view it on GitHub.

[arb]

Under remoteAddress, you can add forwardedFor and set it to req.headers['x-forwarded-for'] Then you don't need the extra option.

[midnightcodr]

Awesome your solution is better. Will update PR tonight. Thanks.

[arb]

Can you rebase this branch? 7 commits for a single line change is a bit much 😄

[midnightcodr]

Agreed :) I just did. See if you can merge now. Thanks for being so patient with a complete PR newbie.

[arb]

Still have 7 commits. At this point it would probably be easier to just start a new local branch and make the changes there since it's only one line.

[midnightcodr]

Learned how to squash. How about now? Thanks.

[arb]

Can you please add or update a test showing that this works? Both in cases where this header is set and unset?

[arb]

UPDATE actually before we make this change, have you tried setting logRequestHeaders to true? That dumbs all the headers out as well and the "x-forwarded-for" header should be in there.

[midnightcodr]

Yup you nailed it. Should've tried that option first. Will close the PR soon.