Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hapi updates #267

Merged
merged 10 commits into from Dec 3, 2014
Merged

Hapi updates #267

merged 10 commits into from Dec 3, 2014

Conversation

@arb
Copy link
Contributor

arb commented Nov 28, 2014

  • Updates to support the new Hapi 8 API
  • Fixes for network and associated tests (old network was double and triple counting requests)
  • Updated network tests because they weren't really doing anything before
  • Removed Node 11 temporary to prevent breaking build because of npm changes
  • Added tests to validate schema of outbound events

Closes #259
Closes #257
Closes #256
Closes #255
Closes #223
Closes #268

@arb arb added this to the 5.0.0 milestone Nov 28, 2014
@arb arb assigned geek Nov 28, 2014
var monitor = new Monitor(pack, options);
};
var fn = function () {
var monitor = new Monitor(new Hapi.Server(), options);

This comment has been minimized.

Copy link
@geek

geek Nov 30, 2014

Member

newline

monitor.start(function () {});
}).to.throw('Every reporter object must have a start and stop function.');
monitor = new Monitor(new Hapi.Server(), options);
monitor.start(function () {});

This comment has been minimized.

Copy link
@geek

geek Nov 30, 2014

Member

You can use Hoek.ignore

@@ -2,6 +2,7 @@

var Code = require('code');
var Lab = require('lab');

This comment has been minimized.

Copy link
@geek

geek Nov 30, 2014

Member

no need for extra newline

var Lab = require('lab');

This comment has been minimized.

Copy link
@geek

geek Nov 30, 2014

Member

can remove extra newline

@@ -7,11 +7,12 @@ var Os = require('os');

var Async = require('async');
var Hoek = require('hoek');
var System = require('./system');

This comment has been minimized.

Copy link
@geek

geek Nov 30, 2014

Member

no need for extra breaks

.travis.yml Outdated
@@ -1,5 +1,4 @@
language: node_js

node_js:
- 0.10
- 0.11
- 0.10

This comment has been minimized.

Copy link
@lloydbenson

lloydbenson Dec 1, 2014

Contributor

needs newline

@miguelcobain

This comment has been minimized.

Copy link

miguelcobain commented Dec 3, 2014

👍

geek added a commit that referenced this pull request Dec 3, 2014
@geek geek merged commit 7b71d76 into hapijs:master Dec 3, 2014
@miguelcobain

This comment has been minimized.

Copy link

miguelcobain commented Dec 4, 2014

When will this get published on npm? It would be a lot easier.

@arb

This comment has been minimized.

Copy link
Contributor Author

arb commented Dec 4, 2014

There was a Tweet by https://twitter.com/hapijs/status/540307309273284608 - npm install good@5.0.0-rc1

@miguelcobain

This comment has been minimized.

Copy link

miguelcobain commented Dec 4, 2014

Sorry, I missed that. Thanks!

@miguelcobain

This comment has been minimized.

Copy link

miguelcobain commented Dec 4, 2014

My output:

$ npm install good@5.0.0-rc1 --save
npm ERR! Error: version not found: good@5.0.0-rc1
npm ERR!     at /usr/lib/node_modules/npm/lib/cache/add-named.js:125:12
npm ERR!     at saved (/usr/lib/node_modules/npm/node_modules/npm-registry-client/lib/get.js:167:7)
npm ERR!     at Object.oncomplete (fs.js:107:15)
npm ERR! If you need help, you may report this *entire* log,
npm ERR! including the npm and node versions, at:
npm ERR!     <http://github.com/npm/npm/issues>

npm ERR! System Linux 3.2.0-68-generic
npm ERR! command "/usr/bin/node" "/usr/bin/npm" "install" "good@5.0.0-rc1" "--save"
npm ERR! cwd /home/jcandrade/Documents/workspace/hapi-boilerplate
npm ERR! node -v v0.10.33
npm ERR! npm -v 1.4.28
npm ERR! 
npm ERR! Additional logging details can be found in:
npm ERR!     /home/jcandrade/Documents/workspace/hapi-boilerplate/npm-debug.log
npm ERR! not ok code 0

Also https://www.npmjs.org/package/good states that the last version is 4.0.2, that's why I asked.

@arb

This comment has been minimized.

Copy link
Contributor Author

arb commented Dec 4, 2014

Ops 🐑. Should be good now! 5.0.0-rc is intentionally NOT the latest version as it is still a release candidate. Also, please open new issues going forward as this issue has been closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.