Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze event objects to prevent tampering #280

Merged
merged 3 commits into from Dec 19, 2014
Merged

Freeze event objects to prevent tampering #280

merged 3 commits into from Dec 19, 2014

Conversation

@arb
Copy link
Contributor

arb commented Dec 16, 2014

Closes #278

Some reporters try to change the eventData object in each of the reporters, while this is "OK" for reporters under the hapijs umbrella, outsides reporters might change the event and cause downstream impacts.

Per this perf, the performance impact should be negligible at best.

@arb arb assigned geek Dec 16, 2014
@arb arb added this to the 5.0.1 milestone Dec 16, 2014
@arb arb added the feature label Dec 16, 2014
@arb arb assigned cjihrig and unassigned geek Dec 19, 2014
cjihrig added a commit that referenced this pull request Dec 19, 2014
Freeze event objects to prevent tampering
@cjihrig cjihrig merged commit 156a480 into hapijs:master Dec 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.