Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'request' event to listen for request.log #282

Closed
wants to merge 1 commit into from

Conversation

@arb
Copy link
Contributor

arb commented Dec 17, 2014

Closes #190

FINALLY can do this now 馃憤

@arb arb added the feature label Dec 17, 2014
@arb arb added this to the 5.1.0 milestone Dec 17, 2014
@arb arb assigned geek Dec 17, 2014
@phated

This comment has been minimized.

Copy link

phated commented Dec 17, 2014

What are your thoughts on request-internal also? It should be the same except hapi is generating them.

@arb

This comment has been minimized.

Copy link
Contributor Author

arb commented Dec 18, 2014

I think the "request-internal" event would generate A LOT of log noise if we expose it. That was part of the motivation of creating the "request-internal" event; to cut down on noise. What information do you want that you can't get via one of the other events?

If people really want it, we can revisit and make that change.

@arb arb mentioned this pull request Dec 18, 2014
@arb

This comment has been minimized.

Copy link
Contributor Author

arb commented Dec 18, 2014

Will open a new PR when the others have been merged.

@arb arb closed this Dec 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.