Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed event for incoming request. #290

merged 1 commit into from Jan 8, 2015

Changed event for incoming request. #290

merged 1 commit into from Jan 8, 2015


Copy link

arb commented Jan 8, 2015

Because the "onRequest" extension point could be side-stepped by an earlier "onRequest" extension point and cause downstream impacts, I changed to listen for the "request-internal" event because I think it happens earlier in the life cycle and can't be interrupted.

I also removed a few unnecessary process.nextTick calls.

Closes #285

@arb arb added the bug label Jan 8, 2015
@arb arb added this to the 5.1.1 milestone Jan 8, 2015
@arb arb assigned geek Jan 8, 2015
geek added a commit that referenced this pull request Jan 8, 2015
Changed event for incoming request.
@geek geek merged commit 98cee5d into hapijs:master Jan 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.