Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report on wreck requests #317

Merged
merged 8 commits into from Mar 31, 2015
Merged

Report on wreck requests #317

merged 8 commits into from Mar 31, 2015

Conversation

@geek
Copy link
Member

geek commented Mar 26, 2015

No description provided.

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Mar 26, 2015

love this feature!

@lloydbenson

This comment has been minimized.

Copy link
Contributor

lloydbenson commented Mar 30, 2015

One of the tests is not passing. I kicked it off again but seems to be consistently failing. Overall looks good though and a very useful feature! Thanks Wyatt!

@lloydbenson

This comment has been minimized.

Copy link
Contributor

lloydbenson commented Mar 30, 2015

Assing this to @arb just to make sure it doesnt conflict with any of the new stuff hes doing to do the final review assuming you get the test working.

@arb

This comment has been minimized.

Copy link
Contributor

arb commented Mar 31, 2015

Build is failing but it looks good otherwise.

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Mar 31, 2015

you missed a semicolon ;)

lib/utils.js:
        Line 182: semi - Missing semicolon.
@arb arb added this to the 6.0.0 milestone Mar 31, 2015
@arb arb added the feature label Mar 31, 2015
arb added a commit that referenced this pull request Mar 31, 2015
Report on wreck requests
@arb arb merged commit 9e4e405 into hapijs:master Mar 31, 2015
@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Mar 31, 2015

can't wait for 6.0, thanks @geek for the PR!

@geek

This comment has been minimized.

Copy link
Member Author

geek commented Mar 31, 2015

Me either, @arb or @lloydbenson when is 6.0 going to be released!?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.