Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved to use Oppsy. Closes #392. #404

Merged
merged 3 commits into from Nov 18, 2015
Merged

Moved to use Oppsy. Closes #392. #404

merged 3 commits into from Nov 18, 2015

Conversation

@arb
Copy link
Contributor

arb commented Nov 18, 2015

  • Use the Oppsy object
  • Remove all the ops collecting code and tests
  • Updated API to reflect change
  • Update tests
- Use the Oppsy object
- Remove all the ops collecting code and tests
- Updated API to reflect change
- Update tests
@arb arb added this to the 7.0.0 milestone Nov 18, 2015
arb added 2 commits Nov 18, 2015
@arb arb added the dependency label Nov 18, 2015
@@ -182,8 +137,13 @@ internals.Monitor.prototype.start = function (callback) {
self._server.on(event, handler);
});

self.on('ops', self._state.opsHandler);
self._ops.on('ops', self._opsHandler.bind(self));
self._ops.on('error', function (err) {

This comment has been minimized.

Copy link
@cjihrig

cjihrig Nov 18, 2015

Contributor

hm, the linter didn't ask for an arrow function here?

This comment has been minimized.

Copy link
@arb

arb Nov 18, 2015

Author Contributor

This is using version 6 at present. I have another task to go through and ES2015 things up.

#394

This comment has been minimized.

Copy link
@cjihrig

cjihrig Nov 18, 2015

Contributor

Ah, my bad then

@cjihrig

This comment has been minimized.

Copy link
Contributor

cjihrig commented Nov 18, 2015

LGTM. All the red is easy on the eyes

arb added a commit that referenced this pull request Nov 18, 2015
Moved to use Oppsy. Closes #392.
@arb arb merged commit 3e8bddd into hapijs:v7.0.0 Nov 18, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@arb arb deleted the arb:oppsy branch Nov 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.