Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #407. #417

Merged
merged 2 commits into from Dec 5, 2015
Merged

Closes #407. #417

merged 2 commits into from Dec 5, 2015

Conversation

@arb
Copy link
Contributor

arb commented Dec 4, 2015

  • Monitoring starts on registration
  • Monitoring stops on onPostStop
  • Ops starts on onPreStart
- Monitoring starts on registration
- Monitoring stops on onPostStop
- Ops starts on onPreStart
@arb arb added the breaking changes label Dec 4, 2015
@arb arb added this to the 7.0.0 milestone Dec 4, 2015
const internals = {
monitorFactory(server, options) {

const defualts = {

This comment has been minimized.

Copy link
@cjihrig

cjihrig Dec 4, 2015

Contributor

defaults

},
filter: {}
};
return new Monitor(server, Object.assign({}, defualts, options));

This comment has been minimized.

Copy link
@cjihrig

cjihrig Dec 4, 2015

Contributor

defaults

@@ -19,6 +19,25 @@ const GoodReporter = require('./helper');
const Monitor = require('../lib/monitor');
const Utils = require('../lib/utils');

// Delcare internals

This comment has been minimized.

Copy link
@cjihrig

cjihrig Dec 4, 2015

Contributor

Declare

const plugin = {
register: Good.register,
options: {
responseEvent: 'fobar'

This comment has been minimized.

Copy link
@cjihrig

cjihrig Dec 4, 2015

Contributor

foobar?

cjihrig added a commit that referenced this pull request Dec 5, 2015
Closes #407.
@cjihrig cjihrig merged commit e60b4a6 into hapijs:v7.0.0 Dec 5, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@arb arb deleted the arb:starts-and-stops branch Dec 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.