Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upEnd cleanup #419
Merged
End cleanup #419
Conversation
This comment has been minimized.
This comment has been minimized.
|
I recommend updating to lab 8 to get the latest linting since you are cleaning up |
lib/monitor.js
Outdated
| this._dataStream.push(null); | ||
| // Do a nextTick here so that all the streams listening for "end" have a chance to run | ||
| // https://github.com/nodejs/node/blob/master/lib/_stream_readable.js#L894-L897 | ||
| return process.nextTick(callback); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Marsup
Dec 8, 2015
Member
Because setImmediate lets IO a chance to run, nextTick doesn't necessarily, I thought it was your intention.
This comment has been minimized.
This comment has been minimized.
arb
Dec 8, 2015
Author
Contributor
I was just flailing tying to figure out why the "end" event wasn't happening, when I added this the "end" event consistently happens. Since technically IO could be happening in the streams, setImmediate makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
arb commentedDec 8, 2015
Closes #413. Push null to the data stream for EOF.
Closes #415. Remove "stop" event.