Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add httpVersion to GreatResponse #421

Merged
merged 1 commit into from Feb 4, 2016
Merged

Add httpVersion to GreatResponse #421

merged 1 commit into from Feb 4, 2016

Conversation

@hostiphur
Copy link
Contributor

hostiphur commented Dec 14, 2015

This data is needed when trying to create a custom reporter for the apache combined log format.

@arb

This comment has been minimized.

Copy link
Contributor

arb commented Dec 15, 2015

Did you run npm test before opening this pull request?

@arb arb self-assigned this Dec 15, 2015
@hostiphur

This comment has been minimized.

Copy link
Contributor Author

hostiphur commented Jan 21, 2016

I apologize for not getting back to you sooner. I've been very busy the past month. The issue was that I didn't add the new property to the schema in the test. I have added it and everything seems to be in order now.

@arb arb added the feature label Jan 21, 2016
@arb

This comment has been minimized.

Copy link
Contributor

arb commented Jan 31, 2016

Can you please rebase this into a single commit and include the phrase "Closes #410"

…ng' test, and documenting it. Closes #410
@hostiphur hostiphur force-pushed the hostiphur:master branch from 37191e7 to 501709a Feb 4, 2016
@hostiphur

This comment has been minimized.

Copy link
Contributor Author

hostiphur commented Feb 4, 2016

Done and done :)

@arb arb added this to the 6.5.0 milestone Feb 4, 2016
arb added a commit that referenced this pull request Feb 4, 2016
Add httpVersion to GreatResponse
@arb arb merged commit fafd90c into hapijs:master Feb 4, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@arb

This comment has been minimized.

Copy link
Contributor

arb commented Feb 4, 2016

Would you be able to make the same change against the v7.0.0 branch here so I don't create a regression?

@hostiphur

This comment has been minimized.

Copy link
Contributor Author

hostiphur commented Feb 4, 2016

Certainly. Forgive me but I'm no git guru. Would I need to make the change manually, or is there some other method I should follow to make this change to v7.0.0?

@arb

This comment has been minimized.

Copy link
Contributor

arb commented Feb 4, 2016

Making it manually would be the easiest way considering how much the code has changed.

@hostiphur

This comment has been minimized.

Copy link
Contributor Author

hostiphur commented Feb 4, 2016

OK, that won't be a problem. It's such a minor change anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.