Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors #462

Merged
merged 2 commits into from Mar 18, 2016
Merged

Errors #462

merged 2 commits into from Mar 18, 2016

Conversation

@arb
Copy link
Contributor

arb commented Mar 18, 2016

Listen for errors on the reporters.

@arb arb added this to the 7.0.0 milestone Mar 18, 2016
@arb arb force-pushed the errors branch from e25bcc9 to 3c4d406 Mar 18, 2016
@@ -70,6 +69,40 @@ describe('Monitor', () => {
});
});

it('logs and destroys a reporter in the event of a stream error', { }, (done) => {

This comment has been minimized.

Copy link
@vdeturckheim

vdeturckheim Mar 18, 2016

Should it have { plan: 3 } ?

This comment has been minimized.

Copy link
@arb

arb Mar 18, 2016

Author Contributor

Nice catch.

@arb arb force-pushed the errors branch from 3c4d406 to d799fd0 Mar 18, 2016
arb added a commit that referenced this pull request Mar 18, 2016
Errors
@arb arb merged commit 4023b98 into master Mar 18, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@arb arb deleted the errors branch Mar 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.