Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request route tags to response event #516

Merged
merged 2 commits into from Sep 16, 2016
Merged

Add request route tags to response event #516

merged 2 commits into from Sep 16, 2016

Conversation

@csabapalfi
Copy link
Contributor

csabapalfi commented Sep 16, 2016

to enable filtering with good-squeeze

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Sep 16, 2016

Why not expose request.route.settings as a whole?

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Sep 16, 2016

Also the build is failing due to Line 85: no-trailing-spaces - Trailing spaces not allowed. ;)

@csabapalfi

This comment has been minimized.

Copy link
Contributor Author

csabapalfi commented Sep 16, 2016

Ouch, sorry.

The reason for exposing tags at the top level because that's how squeeze looks for them:
https://github.com/hapijs/good-squeeze/blob/master/lib/squeeze.js#L65

to enable filtering with good-squeeze
@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Sep 16, 2016

ah I see then 👍

@arb

This comment has been minimized.

Copy link
Contributor

arb commented Sep 16, 2016

Can you update the documentation to include this new field?

@arb arb self-assigned this Sep 16, 2016
@arb arb added the feature label Sep 16, 2016
@arb arb added this to the 7.1.0 milestone Sep 16, 2016
@csabapalfi

This comment has been minimized.

Copy link
Contributor Author

csabapalfi commented Sep 16, 2016

Sure, added docs for this new field.

@arb arb merged commit b8f923e into hapijs:master Sep 16, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.