Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't create a reporter if no streams were provided. Addresses #534 #535
Conversation
ianwsperber
force-pushed the
ianwsperber:dont-create-reporter-if-no-stream
branch
from
18780d3
to
3589ce3
This comment has been minimized.
This comment has been minimized.
|
Can you update the test to include two reporters, one with enough streams, and one with 0, just to make sure the |
This comment has been minimized.
This comment has been minimized.
|
Good idea @arb - I've updated the test per suggestion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ianwsperber commentedNov 18, 2016
Decided the simplest solution was just to not create the reporter if no stream is provided.
See #534