Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create a reporter if no streams were provided. Addresses #534 #535

Merged
merged 2 commits into from Nov 21, 2016

Conversation

@ianwsperber
Copy link
Contributor

ianwsperber commented Nov 18, 2016

Decided the simplest solution was just to not create the reporter if no stream is provided.

See #534

@ianwsperber ianwsperber force-pushed the ianwsperber:dont-create-reporter-if-no-stream branch from 18780d3 to 3589ce3 Nov 18, 2016
@arb

This comment has been minimized.

Copy link
Contributor

arb commented Nov 21, 2016

Can you update the test to include two reporters, one with enough streams, and one with 0, just to make sure the return doesn't short-circuit the rest of the loop?

@arb arb added this to the 7.1.0 milestone Nov 21, 2016
@arb arb self-assigned this Nov 21, 2016
@arb arb added the bug label Nov 21, 2016
@ianwsperber

This comment has been minimized.

Copy link
Contributor Author

ianwsperber commented Nov 21, 2016

Good idea @arb - I've updated the test per suggestion

@arb arb merged commit f957062 into hapijs:master Nov 21, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.