Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign uprequest.id is now request.info.id since Hapi 17 #580
Merged
Conversation
Since Hapi 17, request.id was moved to request.info.id. Source: hapijs/hapi#3658 > Moved request.id to request.info.id.
This comment has been minimized.
This comment has been minimized.
|
I guess we should add a test for this regression. I can do that too if you need. |
This comment has been minimized.
This comment has been minimized.
EdouardDem
commented
Feb 1, 2018
|
I've tried the same fix and I had the request id back in my logs. |
This comment has been minimized.
This comment has been minimized.
|
Yeah let's add a test for this since it caused a regression. |
This comment has been minimized.
This comment has been minimized.
|
I added some assertions so it does not happen again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
simlevesque commentedFeb 1, 2018
Since Hapi 17, request.id was moved to request.info.id.
Source: hapijs/hapi#3658