Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request.id is now request.info.id since Hapi 17 #580

Merged
merged 2 commits into from Feb 3, 2018
Merged

Conversation

@simlevesque
Copy link
Contributor

simlevesque commented Feb 1, 2018

Since Hapi 17, request.id was moved to request.info.id.

Source: hapijs/hapi#3658

Moved request.id to request.info.id.

Since Hapi 17, request.id was moved to request.info.id.

Source: hapijs/hapi#3658

> Moved request.id to request.info.id.
@simlevesque

This comment has been minimized.

Copy link
Contributor Author

simlevesque commented Feb 1, 2018

I guess we should add a test for this regression. I can do that too if you need.

@EdouardDem

This comment has been minimized.

Copy link

EdouardDem commented Feb 1, 2018

I've tried the same fix and I had the request id back in my logs.

@arb

This comment has been minimized.

Copy link
Contributor

arb commented Feb 2, 2018

Yeah let's add a test for this since it caused a regression.

@arb arb added this to the 8.0.1 milestone Feb 2, 2018
@arb arb added the bug label Feb 2, 2018
@simlevesque

This comment has been minimized.

Copy link
Contributor Author

simlevesque commented Feb 2, 2018

I added some assertions so it does not happen again :)

@arb arb self-assigned this Feb 3, 2018
@arb
arb approved these changes Feb 3, 2018
@arb arb merged commit 8ebbac0 into hapijs:master Feb 3, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.