Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for request event error field #581

Merged
merged 1 commit into from Feb 12, 2018

Conversation

@pthrasher
Copy link
Contributor

pthrasher commented Feb 8, 2018

Hapi has some logic that decides whether to include error or data on the request event object. It does this by simply checking if the log data is an instance of an Error object. This adds support for propagating that field properly. If you pass an error object right now as data, Good is completely unaware of it and simply drops it.

https://github.com/hapijs/hapi/blob/master/lib/core.js#L556-L558

@pthrasher pthrasher force-pushed the pthrasher:pthrasher-add-error-support branch from 7599216 to 9e9d026 Feb 8, 2018
@arb arb added this to the 8.1.0 milestone Feb 12, 2018
@arb arb merged commit 91385ff into hapijs:master Feb 12, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.